Fixes #934 qualification workflows handle dual axis in time profiles #993
Conversation
…al axis in time profiles Also Fixes Open-Systems-Pharmacology#985 The fix requires PR [407](Open-Systems-Pharmacology/TLF-Library#407) from tlf package and might have side effects on the legend order of other plots performed by the reporting engine
|
5 tests fail on windows... |
pchelle
force-pushed
the
934_qualification_dual_axis
branch
from
c97ad81
to
bd53ca2
Compare
R/qualification-time-profile.R
Outdated
| if (isOfLength(requestedAxes, 3)) { | ||
| logError(messages$warningTooManyAxes( | ||
| project = timeProfilePlan$Project, | ||
| simulation = timeProfilePlan$Simulation | ||
| )) | ||
| requestedAxes <- c("Y", "Y2") |
There was a problem hiding this comment.
Why this check 2 times (here and above lines 189-191)?
There was a problem hiding this comment.
Copy/Paste typo.
I am going to remove it.
R/qualification-time-profile.R
Outdated
| simData$yAxis <- ifNotNull(simData$yAxis, simData$yAxis %in% tail(requestedAxes, 1)) | ||
| obsData$yAxis <- ifNotNull(obsData$yAxis, obsData$yAxis %in% tail(requestedAxes, 1)) |
There was a problem hiding this comment.
@pchelle Can you explain what happens in these 2 lines?
There was a problem hiding this comment.
For the right axis feature in the {tlf} package, the variable mapping which axis is used needs to provide logical values such as TRUE correspond to values on the right axis and FALSE values on the left axis.
For intellisense, I am replacing yAxis by y2Axis while adding the explanations below
FALSEy2Axis values correspond to data on the left axisTRUEy2Axis values correspond to data on the right axis- Since yAxis values are included in "Y", "Y2" or "Y3",
TRUEvalues will correspond to the values included (%in%) last found axis
Codecov ReportBase: 76.38% // Head: 76.30% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #993 +/- ##
===========================================
- Coverage 76.38% 76.30% -0.08%
===========================================
Files 64 64
Lines 8430 8563 +133
===========================================
+ Hits 6439 6534 +95
- Misses 1991 2029 +38
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Also Fixes #985
The fix requires PR 407 from tlf package and might have side effects on the legend order of other plots performed by the reporting engine