Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

147 plot obs vs pred #148

Merged

Conversation

pchelle
Copy link
Collaborator

@pchelle pchelle commented Jul 1, 2021

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #148 (499c924) into develop (7600a01) will increase coverage by 1.19%.
The diff coverage is 53.08%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #148      +/-   ##
===========================================
+ Coverage    49.59%   50.78%   +1.19%     
===========================================
  Files           53       54       +1     
  Lines         2561     2408     -153     
===========================================
- Hits          1270     1223      -47     
+ Misses        1291     1185     -106     
Impacted Files Coverage Δ
R/boxwhisker-datamapping.R 0.00% <0.00%> (ø)
R/datamapping-xy.R 30.76% <0.00%> (ø)
R/ddiratio-datamapping.R 0.00% <0.00%> (ø)
R/obs-vs-pred-datamapping.R 0.00% <ø> (ø)
R/plot-ddiratio.R 0.00% <0.00%> (ø)
R/plot-obs-vs-pred.R 0.00% <0.00%> (ø)
R/plot-timeprofile.R 0.00% <ø> (ø)
R/themes.R 0.00% <ø> (ø)
R/tlf-env.R 0.00% <0.00%> (ø)
R/utilities-aesthetics.R 87.50% <ø> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7600a01...499c924. Read the comment docs.

DESCRIPTION Outdated
@@ -41,6 +41,7 @@ Suggests:
gridExtra
VignetteBuilder: knitr
Collate:
'aaa.R'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is aaa.R?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions that are used to create common R expressions (to prevent copy/paste of code) and that are not exported are stored in the script aaa.R; but since these functions are potentially used by any of the remaining functions of the package, I wanted to ensure they are collated first, otherwise build crashes can happen.

I found that other packages used the naming of the files as a solution since they are collated in alphabetical order (e.g. ggplot2 also uses aaa-.R and ospsuite has a zzz.R).

Would something like aaa-utilities.R be more appropriate ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, would be better

@Yuri05 Yuri05 merged commit c30a4d4 into Open-Systems-Pharmacology:develop Jul 7, 2021
@pchelle pchelle deleted the 147-plot-obs-vs-pred branch February 15, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants