Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

209 use ospsuite utils #213

Merged

Conversation

pchelle
Copy link
Collaborator

@pchelle pchelle commented Dec 20, 2021

No description provided.

@pchelle
Copy link
Collaborator Author

pchelle commented Dec 20, 2021

About the use of :: and the difference between Namespace and Imports, I found this: https://r-pkgs.org/namespace.html#imports interesting

From what I understand, the use of :: is especially advised when there is a chance that the function or object name is not unique or was updated by another package (e.g. base::sample vs dplyr::sample).
Since one of the goals of {ospsuite.utils} is to prevent that by centralizing the code, I think it is okay not to specify ospsuite.utils:: in most cases.

@msevestre msevestre merged commit 6434184 into Open-Systems-Pharmacology:develop Dec 21, 2021
@msevestre msevestre deleted the 209-use-ospsuite-utils branch December 21, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants