Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

234 alignment #244

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Conversation

pchelle
Copy link
Collaborator

@pchelle pchelle commented Apr 21, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #244 (60bf65b) into develop (389aadf) will increase coverage by 0.21%.
The diff coverage is 53.91%.

@@             Coverage Diff             @@
##           develop     #244      +/-   ##
===========================================
+ Coverage    51.79%   52.01%   +0.21%     
===========================================
  Files           50       50              
  Lines         2647     2686      +39     
===========================================
+ Hits          1371     1397      +26     
- Misses        1276     1289      +13     
Impacted Files Coverage Δ
R/plotconfiguration.R 98.97% <ø> (ø)
R/themes.R 1.14% <0.00%> (-0.16%) ⬇️
R/utilities-theme.R 29.41% <0.00%> (-0.44%) ⬇️
R/font.R 85.00% <85.00%> (+55.00%) ⬆️
R/plotconfiguration-legend.R 98.14% <88.88%> (-1.86%) ⬇️
R/atom-plots.R 77.57% <100.00%> (-0.11%) ⬇️
R/label.R 100.00% <100.00%> (ø)
R/plotconfiguration-label.R 100.00% <100.00%> (ø)
R/utilities-export.R 81.04% <100.00%> (ø)
R/utilities-legend.R 63.53% <100.00%> (+2.88%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 389aadf...60bf65b. Read the comment docs.

R/font.R Outdated
fontFamily = "",
fontFace = "plain",
angle = 0,
align = "center",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's set the default alignment to "left". seems more convenient

To get better display of final plots themes include the following alignments
xticks, xlabel and ylabel are centered
yticks are right aligned
@Yuri05 Yuri05 merged commit 52f14e0 into Open-Systems-Pharmacology:develop Apr 22, 2022
@pchelle pchelle deleted the 234_alignment branch February 15, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants