Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-angular] outdated zone.js@^0.7.6 peer dependency #1506

Closed
d0x opened this issue Nov 20, 2018 · 2 comments
Closed

[typescript-angular] outdated zone.js@^0.7.6 peer dependency #1506

d0x opened this issue Nov 20, 2018 · 2 comments

Comments

@d0x
Copy link
Contributor

d0x commented Nov 20, 2018

Description

Using the generated client for a new angular 6 application will lead into this warning:

npm WARN my.lib requires a peer of zone.js@^0.7.6 but none is installed. You must install peer dependencies yourself.
openapi-generator version

3.3.3

Command line used for generation
java -jar openapi-generator.jar generate \
                    --skip-validate-spec \
                    --input-spec XXXX  \
                    --generator-name typescript-angular \
                    --output YYY \
                    --invoker-package ZZZ \
                    --additional-properties snapshot=false \
                    --additional-properties supportsES6=true \
                    --additional-properties modelPropertyNaming=camelCase \
                    --additional-properties ngVersion=6.1.1 \
                    --additional-properties withInterfaces=true \
                    --additional-properties providedInRoot=true \
                    --additional-properties useRxJS6=true
Suggest a fix/enhancement

I tried the generated client using Zone.js 0.8.26 and so far everything works fine. But I don't know the internals of it and when zone.js is really used. So I can't suggest a blind update to 0.8.xx. Furthermore I haven't found any compatibility notes between 0.7.xx and 0.8.xx.

@wing328
Copy link
Member

wing328 commented Nov 21, 2018

I tried the generated client using Zone.js 0.8.26 and so far everything works fine. But I don't know the internals of it and when zone.js is really used. So I can't suggest a blind update to 0.8.xx. Furthermore I haven't found any compatibility notes between 0.7.xx and 0.8.xx.

Thanks for testing the upgrade locally and checking to see if there's any compatibility notes. I would recommend submitting a PR to see if the CI catches any issue with the upgrade.

@d0x
Copy link
Contributor Author

d0x commented Nov 21, 2018

Ok, i can do that.

wing328 pushed a commit that referenced this issue Nov 24, 2018
* 1506 allow zonejs 0.7.x and 0.8.x to support a wider range of angular versions

* #1506 Removed zone.js as peer since it comes with angular itself

* #1506 Removed zone.js as peer since it comes with angular itself
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this issue Feb 27, 2019
…>=6. (OpenAPITools#1522)

* 1506 allow zonejs 0.7.x and 0.8.x to support a wider range of angular versions

* OpenAPITools#1506 Removed zone.js as peer since it comes with angular itself

* OpenAPITools#1506 Removed zone.js as peer since it comes with angular itself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants