Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scala-gatling] use the official Gradle plugin #11208

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Jan 2, 2022

This plugin is no longer supported:

https://github.com/lkishalmi/gradle-gatling-plugin

It has been replaced by this plugin:

https://github.com/gatling/gatling-gradle-plugin



PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added Client: Scala Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Jan 2, 2022
@wing328 wing328 added this to the 5.4.0 milestone Jan 2, 2022
@wing328
Copy link
Member

wing328 commented Jan 2, 2022

LGTM. Thanks for the PR.

@wing328 wing328 merged commit 8d532d5 into OpenAPITools:master Jan 2, 2022
@sullis sullis deleted the gatling-gradle-plugin branch January 2, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: Scala Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants