Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better format in C templates #1219

Closed
wants to merge 43 commits into from
Closed

Better format in C templates #1219

wants to merge 43 commits into from

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Oct 11, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Even though one can use a code formatter to format the C client, we still want the C client to have decent code format (e.g. code align properly, etc).

anandshah05 and others added 30 commits September 29, 2018 16:57
* add nullable support to python client

* update PR template
* add hfmt support (without updating the sample)

* update haskell httpclient samples with hfmt

* add code format option to haskell servant, minor bug fixes

* update code samples with hfmt

* update samples using stylish-haskell

* rename env variable

* update haskell samples with stylish-haskell

* regenerate haskell samples without stylish-haskell

* regenerate haskell servant sample

* update example-app & tests-integration for OAS2 code
* Use the same name for all exposed encoder & decoders;
* Improve imports (limit exposures);
* Add support for OAS3 discriminators;
* Distinct between 0.18 & latest mustache files.
* Generate default values for optional model fields in scala-akka

Fix #1118

* Updated akka-client petstore with defaults for optional model fields

* update petstore sample with scalafmt
[Golang][go-gin-server] Fix path parameter naming
* better handling of different types in elm generator

* [elm] Fix toString for special cases
* [Mysql Schema] Add new generator

* [Mysql Schema] Fix default definition

* [Mysql Schema] Add defaultDatabaseName option

* [Mysql Schema] Add jsonDataTypeEnabled option

* [Mysql Schema] Add samples
* minor enhancements to the mysql generator

* add ybelenko to the README
* renmae Go post process file env variable

* add back samples/client/petstore/c/libcurl.licence

* keep go samples up-to-date

* update go petstore samples

* update go samples without formatting
* update using release_version_update

* comment out ensure up to date script

* update using release_version_update_docs

* remove current master
* update version

* update petstore samples
* Allow colons in interface property names: #1080

* replace tabs with spaces

* add docs

* add example in doc

* update docs

* update docs

* remove language specific docs in DefaultCodegen

* Delete addPet-BodyParams.csv

* remove toPropertyName and update toVarName instead for TS
* update README with 3.4.x

* fix div
* remove left|right point double angle quotation marks

* move to DefaultCodeGen and update TypeScriptAngularClientCodegen to reflect new clean function so that the filename AND imports are added correctly

* rename to a more accurate name :)

* shippable fixes

* shippable javadoc fix

* replaced cleanModelFilename with sanitzeName

* remove DefaultCodegen changes
* better format for ruby test

* update ruby petstore
* Pushing the improved fix

* reverting the unrelated change

* saving the revertal properly
* Add test case which reproduces issue340

* Take the first $ref we find in the allOf-List
* fix default, example for java okhttp

* update java feign samples

* update samples, doc

* add new doc for dart-jaguar

* update model template

* update jaxrs spec model

* update resteasy sample

* update java samples
* update plugin version

* update version in CI pom

* use maven 3.2.5
* Start working on fixing default value in Restbed Server Api Template

* fix default value in DefaultCodegen

* Revert "fix default value in DefaultCodegen"

This reverts commit ce69006.

* fix default value in cpprest

* update cpp restbed samples
…th token retry (#1183)

* Fix bug when specifying grant-type for OAuth token retry

* Update samples

* Update security samples
#1132)

* Allow specifying/overriding the parent in the pom file for Java and Spring generators.

* Don't add extra whitespace to the pom file when the parent isn't overridden.

* Remove accidentally added white space.
wing328 and others added 8 commits October 9, 2018 10:25
* update jmockit version

* list jvm

* test jdk9 in appveyor

* use latest version of gradle

* update to jdk9

* use openjdk9

* use default java version in appveyor

* use jdk8 docker image

* consolidate bash, ios pom into parent pom

* consolidate circlecii pom into parent pom

* remove circleci pom.xml
Explicitly adding node.js 8 type definitions before ClientResponse interface was removed due to deprecation.
* Fix character conversion error

ref https://tomcat.apache.org/tomcat-5.5-doc/servletapi/javax/servlet/ServletResponse.html
> To send character data, use the PrintWriter object returned by getWriter()

* Update samples

* Update spring-stubs
* [go] x-www-form-urlencoded-body-fix

* [go] run scripts in bin and bin/security
…other objects (#1089)

* Run ./bin/utils/ensure-up-to-date to re-generate samples run in the CI.

* Fixed the #1088 issue by removing the update of enumeration properties while processing objects that reference them. Launched the ./bin/csharp-petstore-all.sh script.
* verify updatePetWithForm in go client

* update wording
* update readme

* fix logger warning
@wing328
Copy link
Member Author

wing328 commented Oct 11, 2018

cc @PowerOfCreation @zhemant

@wing328
Copy link
Member Author

wing328 commented Oct 12, 2018

Closed via #1224

@wing328 wing328 closed this Oct 12, 2018
@wing328 wing328 deleted the better_format branch October 12, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.