[cpp-qt5] improvements for server and client #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use const reference wherever possible Reuse same super class for Qt5 client and server Support primitive return types for Qt5 client
|
I really like the shape of this! This looks like more C++ now. Thank you for this amazing job! I hope the breaking change won't be a no go for this PR. |
stkrwork
approved these changes
Oct 30, 2018
etherealjoy
added
Breaking change (without fallback)
and removed
Breaking change (with fallback)
labels
|
@wing328 |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
- Remove pointer usage in generated models - Use const reference wherever possible - Reuse same super class for Qt5 client and server - Support primitive return types for Qt5 client - Add const reference to API calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
@stkrwork @MartinDelille @wing328 @ravinikam @fvarose
See #272
See #1175