Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix enum un-alias logic to resolve the problem that $ref-ed enum is not generated correctly. #1325

Closed
wants to merge 1 commit into from

Conversation

fujigon
Copy link
Contributor

@fujigon fujigon commented Oct 26, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This patch fixes #1323

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

…ot generated correctly.

refactor to pass the all definitions of schemas to `fromProperty` method.
copy the ref-ed default value to codegen property.
@fujigon
Copy link
Contributor Author

fujigon commented Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[General] default value of enum property that are $ref-ed is not recognized
1 participant