Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cast list to tuple in python-prior binding #14014

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Don't cast list to tuple in python-prior binding #14014

merged 2 commits into from
Nov 16, 2022

Commits on Nov 16, 2022

  1. Add test for python-prior type conversion error 

    In the spirit of test driven development, this test intentionally fails.
A following commit will fix the code to comply with the test.

See: OpenAPITools#14012
    @Ichimonji10
    Ichimonji10 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    242075b View commit details
    Browse the repository at this point in the history

  2. Don't cast list to tuple in python-prior binding 

    Tweak the python-prior API bindings, so that they no longer cast lists
to tuples when making a POST request with a multipart/form-data
content-type. This fixes an interaction with
`urllib3.request_encode_body`, whose `fields` parameter expects tuples,
not lists.

cc @spacether

See: https://urllib3.readthedocs.io/en/stable/reference/urllib3.request.html

Fix: OpenAPITools#14012
    @Ichimonji10
    Ichimonji10 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    afb7cd8 View commit details
    Browse the repository at this point in the history