Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the Swift4 templates to address the warnings produced by the Swift 4.2 compiler #1407

Merged
merged 2 commits into from
Nov 10, 2018

Conversation

james-rant
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixes issue #1406

Updates the Swift4 templates to address the warnings produced by the Swift 4.2 compiler.

cc: @ehyche

@wing328
Copy link
Member

wing328 commented Nov 9, 2018

cc @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @d-date (2018/03) for review

@d-date
Copy link

d-date commented Nov 10, 2018

Nice catch🐈

@d-date d-date merged commit 5711985 into OpenAPITools:master Nov 10, 2018
@wing328 wing328 changed the title Fix swift4 1406 Updates the Swift4 templates to address the warnings produced by the Swift 4.2 compiler Nov 12, 2018
@james-rant james-rant deleted the fix-swift4-1406 branch November 15, 2018 09:53
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Fix warnings produced when using Swift 4.2

* Update Petstore client for Swift 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants