Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] [Gradle Plugin] Allow templates from classpath #14909

Merged

Conversation

dimber-cais
Copy link
Contributor

Enhance the Gradle plugin to support loading templates from the classpath. This is already a feature of the Maven plugin, and this PR uses the same approach.

@dimber-cais dimber-cais force-pushed the feature/gradle-classpath-templates branch from 14894e0 to 0ee81bd Compare March 8, 2023 21:23
@dimber-cais
Copy link
Contributor Author

This relates to this issue: #14909

@dimber-cais
Copy link
Contributor Author

@jimschubert - would dearly love to see this merged into the project.

@wing328
Copy link
Member

wing328 commented Mar 14, 2023

@dimber-cais thanks for the PR. Can you please add a test or two?

@dimber-cais
Copy link
Contributor Author

@wing328 - I've not been able to successfully add a test for this. It's tricky as it relies on additional JARs being added into the plugin's classpath in order to leverage this feature.

I have however, created a simple example project which demonstrates this behavior, which hopefully provides confidence that this change works as expected.

The project can be found here: https://github.com/dimber-cais/openapi-generator-custom-classpath-templates-example

@wing328 wing328 modified the milestones: 6.5.0, 6.6.0 Apr 1, 2023
@wing328 wing328 modified the milestones: 6.6.0, 7.0.0 May 11, 2023
@dimber-cais
Copy link
Contributor Author

@wing328 - Are you still planning on including this into the 7.0.0 release?

@ko-at-work
Copy link

@wing328 - Are you still planning on including this into the 7.0.0 release?

I am interested in this as well, since this is a missing capability needed for our development. It looks like it is still tagged to the 7.0.0 milestone, but there has been no progress on the PR.

@wing328 wing328 modified the milestones: 7.0.0, 7.0.1 Aug 25, 2023
@wing328 wing328 modified the milestones: 7.0.1, 7.1.0 Sep 19, 2023
@ko-at-work
Copy link

@wing328 Any updates on that PR? Would be great to have it in 7.1.0 🚀

@wing328 wing328 modified the milestones: 7.1.0, 7.2.0 Nov 13, 2023
@wing328 wing328 modified the milestones: 7.2.0, 7.3.0 Dec 22, 2023
@wing328 wing328 modified the milestones: 7.3.0, 7.4.0 Feb 8, 2024
@wwadge
Copy link

wwadge commented Feb 19, 2024

Bump for this - the PR is very minimal and is only setting an existing config: would be great to have this in

@wing328 wing328 removed this from the 7.4.0 milestone Mar 11, 2024
@vzorge
Copy link

vzorge commented Jun 13, 2024

Any update on this PR? It would be a very welcome addition and has been pushed back for over a year. Does it still depend on succesful tests being added @wing328 ?

@wing328
Copy link
Member

wing328 commented Jun 13, 2024

ideally we need a test or 2 but looks like it's not simple to add and no one has time to dig into it.

i'll merge it and please help test the snapshot version (published later as part of CI workflow) to ensure everything works as expected.

@wing328 wing328 merged commit f365900 into OpenAPITools:master Jun 13, 2024
@vzorge
Copy link

vzorge commented Jun 13, 2024

I will do that as soon as it is available (and I am also). I can't find the workflow to see when this is. I will check tomorrow. Also noticed I was still on 7.3.0 so had to resolve some issues upgrading to 7.6.0.

@vzorge
Copy link

vzorge commented Jun 13, 2024

@wing328 Perhaps a silly question, but I can't find how I can use the SNAPSHOT version in my project to test this, apart from building it locally. Is there a way to get the snapshot plugin from the web?
All my attempt end up with an error that 7.7.0-SNAPSHOT cannot be found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants