[Typescript][Fetch] Fix bugs with new typescript-fetch generator #1545
Conversation
- Add `readonly` modifier to readOnly parameters. - Omit readOnly parameters from requests when serializing models - Use allVars in models template when serializing/deserializing requests
|
LGTM cc @Place1 |
someone1
changed the title
|
May as well leave this open for a few days - I'm running into more issues as I try and update my application using the new generator. |
|
I've finished converting my internal application using the new generator and so I think this PR is done. There is one remaining issue regarding If there are any issues with the changes I made, please let me know if I can adjust them to meet the roadmap/goals/direction of the project! Travis is failing due to a timeout issue, I don't think it's due to anything I've done in this PR. |
|
@someone1 thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529. Happy New Year and looking forward to more collaboration and contributions in 2019! |
…nAPITools#1545) * [Typescript][Fetch] Always initialize queryParameters * [Typescript][Fetch] Resolve date and date-time formats to parameter type Date * [Typescript][Fetch] Update models template - Add `readonly` modifier to readOnly parameters. - Omit readOnly parameters from requests when serializing models - Use allVars in models template when serializing/deserializing requests * [Typescript][Fetch] Omit time component when parameter format: date * [Typescript][Fetch] Add moduleResolution: node option to tsconfig.json * [Typescript][Fetch] Added non-model enums
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
Fixes multiple issue with the update typescript-fetch generator
queryParametersvariableDatewhen a string is formatted asdateordate-time"moduleResolution" : "node",option@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)