Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][JAVA] oneOf/anyOf multiple constructors with same erasure #18548 #18645

Merged
merged 2 commits into from
May 13, 2024

Conversation

Bethibande
Copy link
Contributor

This PR fixes a compilation error that appears in generated oneOf and anyOf classes using the okhttp-gson library.
A more detailed explanation can be found in the issue description: #18548
Additionally, two new URLs have been added in modules/openapi-generator/src/test/resources/3_0/java/petstore-with-fake-endpoints-models-for-testing-okhttp-gson.yaml, these requests can be used to test this change.

I also ended up fixing another bug with incorrect variable names when using array types that caused my tests to fail (see adfc6ef, there don't appear to be any issues regarding this error, so I pushed the fix here in order for the tests to pass).

I also didn't add any new tests since the validation and serialization logic weren't modified, the new sample requests will fail the CI tests if the bug occurs.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

@@ -210,13 +210,11 @@ public class {{classname}} extends AbstractOpenApiSchema{{#vendorExtensions.x-im
super("anyOf", {{#isNullable}}Boolean.TRUE{{/isNullable}}{{^isNullable}}Boolean.FALSE{{/isNullable}});
}

{{#anyOf}}
public {{classname}}({{{.}}} o) {
public {{classname}}(Object o) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi. this is consistent with the constructor implementation in oneOf

@wing328 wing328 merged commit cefeded into OpenAPITools:master May 13, 2024
73 checks passed
@wing328 wing328 added this to the 7.6.0 milestone May 14, 2024
renatomameli pushed a commit to renatomameli/openapi-generator that referenced this pull request May 17, 2024
…PITools#18548 (OpenAPITools#18645)

* [BUG][JAVA] oneOf/anyOf multiple constructors with same erasure
OpenAPITools#18548

* [BUG][JAVA] oneOf/anyOf multiple constructors with same erasure
OpenAPITools#18548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants