-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csharp] Improved apiclient.mustache #18915
Conversation
…h Action<> delegate.
Updated samples
@@ -429,236 +431,185 @@ namespace {{packageName}}.Client | |||
return transformed; | |||
} | |||
|
|||
private ApiResponse<T> ExecClient<T>(Func<RestClient, RestResponse<T>> getResponse, Action<RestClientOptions> setOptions, RestRequest request, RequestOptions options, IReadableConfiguration configuration) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a dostring/comment explaining what this function does?
also we can we 4-space instead of tabs for indention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All done!
Added new DRY method DeserializeRestResponseFromPolicy
…mPolicy Updated samples
fyi. appveyor tests passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/50020252 |
return await client.ExecuteAsync<T>(request, cancellationToken).ConfigureAwait(false); | ||
} | ||
}; | ||
return action().Result; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im seeing some issues with the use of .Result here to call the async code from the sync code.
It blocks the UI from rendering in a blazor application and can cause other issues by blocking aync code from yielding.
Improved apiclient.mustache to keep it dry, sharing a single exec with Action<> delegate.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha @wing328