[GdScript] Templates for GdScript (Godot 4) #19267

Goutte · 2024-07-30T07:06:09Z

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh
```
(For Windows users, please run the script in Git BASH)
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

This does not really work yet, but it's a start. Results are not denormalized, no support for enums nor datetimes, and thousands of other features are missing. I still don't know how we are going to denormalize JSON+LD without writing a whole GDScript lib for it…

I've also provided the small python script I used to generate the list.

Whilst I'm racking my brains trying to figure out integration testing…

(plain ol' godot object) One: I don't know how they work under-the-hood. Two: I'm very confused over-the-hood. Tri: We do not need them.

I know I'm making a lot of commits for not much, but now I'm opening the sample files with Godot as well, and doing unholy things with filesystems, so I'm not taking any chances. It's all going to be squashed anyway. :)

It works ! I can now write integration tests in GDScript. The real work starts now. /spend 25h

The test suite is now past its first hurdle, the 415 HTTP status code, and went straight into an unexpected error 500. I suspect the server does not like me trying to set the pet id at 0, because that's what we're trying to do right now. Godot is crashing a lot, mostly because I don't know how to make Callable.NOOP and my current solution hints at optional on_success and on_failure, yet if we omit them the engine will ragequit.

Now we'll get a nice error when we forget to set a required property. The demo is now able to: - connect - create a user - login as that user - create a pet

This makes our usage of `class_name` a little more acceptable.

This will crutch namespacing well enough for most uses.

- minLength - maxLength - minItems - maxItems - minimum - maximum - pattern (no flags)

We also support serializing to application/x-www-form-urlencoded now. Next up: DateTimes !

There's no timezone support in Godot for DateTimes.

Those are Arrays, not custom collection objects.

We don't need no factories nor singletons ; config is enough.

…gure features We can now generate a client for an OAS server running ApiPlatform (PHP).

(but I can't find the `description` template handler)

Too late to amend >.<

dangsarnit

There's still a lot of holes, TODOs and FIXMEs.

The inline response objects are still not supported.

{{#if defaultValue}} evaluates to true for null if we call super here.

Now we pass the config and the client via the constructor. This reduces the area of the public surface a bit, for the better I think. This commit also cleans up the class name shenanigans.

… addon Since there is no singleton in the generated client, the addon need not be enabled in the project configuration to be usable. The --headless mode is broken for now, as things changed in Godot 4 since the beta.

We used the latest stable GUT, but a feature we're going to need was merged today, so we'll need to update it either to master or to the next release at some point.

…lbacks /spent 6d since the beginning

/spend 2h

Also moving core templates to their own subdir, for clarity. /spend 10m

/spend 2h

/spend 7m

/spend 2h

Hire me while I'm available ! :D I'd rather code than make a CV.

Also adding some more assertions, and using our own OAS file now. /spend 3h

/spend 1h

@jchu231

Contributed by @jchu231

Goutte · 2024-07-30T07:14:35Z

Should I add myself to the tech committee for GdScript ?

Goutte · 2024-07-30T08:56:23Z

I rebased on main, and the test suite now fails.

java.lang.IllegalAccessException: class com.github.jknack.handlebars.context.FieldValueResolver$FieldMember cannot access a member of class java.util.HashMap (in module java.base) with modifiers "transient"

com.github.jknack.handlebars.HandlebarsException: model.handlebars:3:3: java.lang.IllegalStateException: Shouldn't be illegal to access field 'size' model.handlebars:3:3

I'll hunt some more in the coming days.

Of interest : jknack/handlebars.java#940
and : #510

wing328 · 2024-07-30T17:54:26Z

Should I add myself to the tech committee for GdScript ?

yes please

Goutte and others added 30 commits July 30, 2024 08:08

feat: add an exhaustive list of keywords reserved in GDScript

5c436d3

I've also provided the small python script I used to generate the list.

refacto(gdscript): start using partials in templates

a4924ca

Whilst I'm racking my brains trying to figure out integration testing…

test(gdscript): prepare a demo and integration testing

8de37d1

fix(gdscript): do not use subclasses, use plain POGO

f7366fb

(plain ol' godot object) One: I don't know how they work under-the-hood. Two: I'm very confused over-the-hood. Tri: We do not need them.

refacto(gdscript): move demo files to their own directory

722b56b

I know I'm making a lot of commits for not much, but now I'm opening the sample files with Godot as well, and doing unholy things with filesystems, so I'm not taking any chances. It's all going to be squashed anyway. :)

fix(gdscript): sample as a Godot project

77e3b85

It works ! I can now write integration tests in GDScript. The real work starts now. /spend 25h

feat(gdscript): check request body for required yet missing properties

ec62d55

Now we'll get a nice error when we forget to set a required property. The demo is now able to: - connect - create a user - login as that user - create a pet

feat(gdscript): namespace core classes as well with apiPrefixName

b403056

This makes our usage of `class_name` a little more acceptable.

feat(gdscript): support prefixes and suffixes for class names

1b83f57

This will crutch namespacing well enough for most uses.

feat(gdscript): handle enums, naively

32dfb4b

feat(gdscript): support basic API endpoint param constraints

90c2962

- minLength - maxLength - minItems - maxItems - minimum - maximum - pattern (no flags)

feat(gdscript): handle header params and header customization

13ea8a9

We also support serializing to application/x-www-form-urlencoded now. Next up: DateTimes !

feat(gdscript): handle Date and DateTime like Strings

4458212

There's no timezone support in Godot for DateTimes.

feat(gdscript): support plain text responses

9cb6c52

feat(gdscript): support collections of models

e565add

Those are Arrays, not custom collection objects.

feat(gdscript): configure default host from OAS

afb451a

feat(gdscript): some documentation and better config

5ae755d

We don't need no factories nor singletons ; config is enough.

docs(gdscript): document usage a little

04f4d3f

feat(gdscript): add more reserved words, skip jsonld models and confi…

a7bc60e

…gure features We can now generate a client for an OAS server running ApiPlatform (PHP).

feat(gdscript): improve logging with a configurable log level

07a8076

feat(gdscript): add support for Basic Bearer and Header ApiKey

e131124

(but I can't find the `description` template handler)

fix(gdscript)

6cf380f

Too late to amend >.<

fix(gdscript)

85d3b6e

dangsarnit

chore(gdscript): clean up a sprint artifact

bd5f805

fix: don't forget the HTTP error code when relevant

35f2146

feat: use Resource as base class for models

96d2db0

fix. Default string values now with "quotes"

004040e

temporary remove settings as godot api have changed

a0c79e4

saatsazov and others added 24 commits July 30, 2024 08:08

kick ci

bae1399

docs: review gdscript java class

fd47ffa

feat: support for TLS, some refacto, some review

fdbf5b7

There's still a lot of holes, TODOs and FIXMEs.

feat: experimental support of Request inline objects

407489d

The inline response objects are still not supported.

feat(gdscript): support inline request and response objects

1b290b9

chore(gdscript): review the templates

6491c91

fix(gdscript): unexpected nulls in default values

696dea0

{{#if defaultValue}} evaluates to true for null if we call super here.

refacto(gdscript): replace "bee" prefix by "bzz", use a constructor

39600e7

Now we pass the config and the client via the constructor. This reduces the area of the public surface a bit, for the better I think. This commit also cleans up the class name shenanigans.

fix(gdscript): add missing file

95e3d58

docs(gdscript): document petstore server ADR

206cef9

test(gdscript): add GUT and an integration test

a0b1e4d

We used the latest stable GUT, but a feature we're going to need was merged today, so we'll need to update it either to master or to the next release at some point.

refacto(gdscript, breaking): use an ApiResponse object in success cal…

c4fda71

…lbacks /spent 6d since the beginning

test(gdscript): update integration tests

31868ca

/spend 2h

docs(gdscript): explain the new ApiResponse

edce567

Also moving core templates to their own subdir, for clarity. /spend 10m

chore(gdscript): review, document, clean up

acede28

/spend 2h

test(gdscript): test the delete operation as well

7074250

/spend 7m

feat(gdscript): update GUT and exit with appropriate code

0b73f1c

/spend 2h

docs(gdscript): add Gdscript's PI

ec7edfc

Hire me while I'm available ! :D I'd rather code than make a CV.

feat(gdscript): support reserved keywords

b3a1bed

Also adding some more assertions, and using our own OAS file now. /spend 3h

refacto(gdscript): use "base" instead of "bee"

516e1ab

/spend 1h

feat(gdscript): improve descriptions

75f6cad

/spend 1h

fix(gdscript): await before polling

28efebd

Contributed by @jchu231

docs(gdscript): review the template files

c47b7a1

Goutte changed the title ~~Templates for GdScript (Godot 4)~~ [GdScript] Templates for GdScript (Godot 4) Jul 30, 2024

docs(gdscript): review and generate docs

89f6ab5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GdScript] Templates for GdScript (Godot 4) #19267

[GdScript] Templates for GdScript (Godot 4) #19267

Goutte commented Jul 30, 2024 •

edited

Loading

Goutte commented Jul 30, 2024

Goutte commented Jul 30, 2024 •

edited

Loading

wing328 commented Jul 30, 2024

[GdScript] Templates for GdScript (Godot 4) #19267

Are you sure you want to change the base?

[GdScript] Templates for GdScript (Godot 4) #19267

Conversation

Goutte commented Jul 30, 2024 • edited Loading

PR checklist

Goutte commented Jul 30, 2024

Goutte commented Jul 30, 2024 • edited Loading

wing328 commented Jul 30, 2024

Goutte commented Jul 30, 2024 •

edited

Loading

Goutte commented Jul 30, 2024 •

edited

Loading