Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Pistache] Fix 'unused-parameter' warning on Helpers.h file #19315

Merged

Conversation

sjoubert
Copy link
Contributor

@sjoubert sjoubert commented Aug 7, 2024

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd

@wing328 wing328 added this to the 7.8.0 milestone Aug 14, 2024
@wing328 wing328 merged commit d55525f into OpenAPITools:master Aug 14, 2024
15 checks passed
@sjoubert
Copy link
Contributor Author

Hi @wing328, thanks for the merge.
For correctness this issue should be labeled Server: C++ not Client: C++.

@sjoubert sjoubert deleted the pistache-fix-unused-param-helpers branch August 14, 2024 06:51
@wing328
Copy link
Member

wing328 commented Aug 14, 2024

good catch. fixed.

when you've time, can you please PM me via Slack? thanks

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants