Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerShell] Fix response type on deserialization #19331

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

condorcorde
Copy link
Contributor

This PR fixes an issue when the received response is of type application/octet-stream rather than application/json.
DeserializeResponse in api_client.mustache expects a parameter of type string. Since the associated type of a binary content type is Byte[] and no intrinsic conversion exists, an exception is thrown.

The commit modifies the type of the parameter $Response to Object, so the function can handle both text and binary response bodies (if it is binary and the Content-Type of the response is correct, the parameter is returned as-is).

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @wing328

@wing328
Copy link
Member

wing328 commented Aug 11, 2024

thanks for the PR

appveyor ci tests passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/50384517

@wing328 wing328 merged commit 6da3dc5 into OpenAPITools:master Aug 11, 2024
20 checks passed
@wing328 wing328 added this to the 7.8.0 milestone Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants