Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust template folder to lang option #2959

Merged
merged 3 commits into from
May 22, 2019

Conversation

karismann
Copy link
Contributor

@karismann karismann commented May 21, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.

Description of the PR

adjust template folder to lang option :

  • scala-finch
  • java-msf4j
  • java-undertow
  • php-ze-ph

see #138 (comment)

cc @ackintosh

Copy link
Contributor

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ackintosh ackintosh merged commit 6a1f33d into OpenAPITools:master May 22, 2019
@ackintosh ackintosh added this to the 4.0.1 milestone May 22, 2019
@karismann karismann deleted the issue-138 branch May 22, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants