[Qt5 Server] Add Support for Qt5 server using QHttpEngine #322

etherealjoy · 2018-06-14T12:11:04Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Qt5 Server based on QHttpEngine

Supports Transient Objects for Multi Requests
Supports Query parameters
Supports Path Parameters
Support Serialization/DeSerialization of Response/Request
Run and build in debian stretch slim container

Missing Support

Map Serialization for response
Containers of Primitive types in response (due to this issue [cpp-qt5] Escape language reserved symbols which are valid in the spec #281 )
Primitive types in response (Missing in client as well)

Related to discussion in #268

@stkrwork @MartinDelille @ravinikam @fvarose @wing328

wing328 · 2018-06-14T15:51:56Z

Suggestion: You may consider creating an abstract "AbstractCppQt5Codegen.java" class for both Qt5 client and server codegen classes in this PR or a separate PR (day 2 requirement)

etherealjoy · 2018-06-14T16:23:37Z

Can we also share templates?
Also C++ does not have package name I wonder what to use.

wing328 · 2018-06-14T16:44:38Z

Can we also share templates?

Technically yes and that requires changes in the Qt5 client codegen as well.

wing328 · 2018-06-14T17:32:48Z

Also C++ does not have package name I wonder what to use.

What about namespace? C++ QT5 client has the following option:

https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/CppQt5ClientCodegen.java#L98

Wired up main TODO : Route API call to handlers

…ainer and on the host

…erver-wip

…r Dockerfile

stkrwork

not done with reviews, but that what i saw in the java file

stkrwork · 2018-06-28T10:42:10Z

.../openapi-generator/src/main/java/org/openapitools/codegen/languages/CppQt5ServerCodegen.java

+         * Template Location.  This is the location which templates will be read from.  The generator
+         * will use the resource stream to attempt to read the templates.
+         */
+        embeddedTemplateDir = templateDir = "cpp-qt5-server";


Didn't you say there is more than one framework for qt server, which might be interesting to look at? wouldnt it be better then to specifiy which one it is?

Add framework information

stkrwork · 2018-06-28T10:44:09Z

.../openapi-generator/src/main/java/org/openapitools/codegen/languages/CppQt5ServerCodegen.java

+         */
+        languageSpecificPrimitives = new HashSet<String>(
+                Arrays.asList(
+                        "bool",


char is not there in OAS

stkrwork · 2018-06-28T10:47:12Z

.../openapi-generator/src/main/java/org/openapitools/codegen/languages/CppQt5ServerCodegen.java

+     */
+    @Override
+    public String getName() {
+        return "cpp-qt5-server";


stkrwork · 2018-06-28T10:47:26Z

.../openapi-generator/src/main/java/org/openapitools/codegen/languages/CppQt5ServerCodegen.java

+     */
+    @Override
+    public String getHelp() {
+        return "Generates a Qt5 C++ server library.";


with which framework?

Add framework information

stkrwork · 2018-06-30T15:46:28Z

why close it?

JohnAmadis · 2018-07-02T09:13:32Z

samples/server/petstore/cpp-qt5-server/server/src/models/OAIHelpers.cpp

+        return;
+    }
+    if(QStringLiteral("bool").compare(type) == 0) {
+        bool * val = static_cast<bool*>(value);


I think you can use qvariant_cast and QVariant here to avoid storing pointers

I tried it and sadly the model became complicated :|

wing328 · 2018-07-03T08:47:21Z

Hi all, do you think this generator is ready for a beta release?

etherealjoy · 2018-07-03T11:54:39Z

@wing328
@stkrwork wanted to add some comments so I will wait for him.

wing328 · 2018-07-08T05:11:05Z

👌 please take your time. I was wondering it's ready for a beta release so as to collect more feedback from the community.

…fy model, add emit signals to default handlers

etherealjoy · 2018-07-26T09:01:02Z

@wing328
We can do a beta and see if we can get feedback.

…ls#322) * Initial wiring to get the QHttpEngine Server running for Qt5 server * Add wiring for build environment * Add current generated files * Update README.md * Solved Build for Docker and Host Wired up main TODO : Route API call to handlers * Wire up routes * Wiring up routes update * Convert Path to QHttpEngine format * Rename some files * Extract query Parameters and path parameters * Removed pri file, Qt can read CMakeLists.txt * Initial support of deserialization * Adding initial support for response serialization * Setup simple signal handler to quite the server with Ctrl+C in a container and on the host * Remove unneeded function * Add executable permission to script and move from Debian to Alpine for Dockerfile * Add stringValue of missing types * Unify toJson'xxx' APIs the same way like setValue * Rework to remove all pointer usages, pass by const references, simplify model, add emit signals to default handlers

etherealjoy added 5 commits June 14, 2018 12:01

Initial wiring to get the QHttpEngine Server running for Qt5 server

6a41550

Merge remote-tracking branch 'upstream/master' into cpp-qt5-server_draft

c68af61

Add wiring for build environment

f8dd5ab

Add current generated files

79dec6f

Update README.md

a386f4d

wing328 added Server: C++ Enhancement: New generator labels Jun 14, 2018

etherealjoy added 9 commits June 15, 2018 13:11

Solved Build for Docker and Host

154836d

Wired up main TODO : Route API call to handlers

Wire up routes

76ffcab

Wiring up routes update

137b248

Convert Path to QHttpEngine format

0d7a72a

Rename some files

b1b8dea

Extract query Parameters and path parameters

cc4b1bd

Removed pri file, Qt can read CMakeLists.txt

bf1c96a

Initial support of deserialization

1b4404c

Adding initial support for response serialization

421a176

etherealjoy changed the title ~~[Qt5 Server] WIP Add Support for Qt5 server using QHttpEngine~~ [Qt5 Server] Add Support for Qt5 server using QHttpEngine Jun 16, 2018

etherealjoy added 6 commits June 17, 2018 12:30

Setup simple signal handler to quite the server with Ctrl+C in a cont…

34f100d

…ainer and on the host

Remove unneeded function

1984800

Merge remote-tracking branch 'remotes/upstream/master' into cpp-qt5-s…

2401414

…erver-wip

Add executable permission to script and move from Debian to Alpine fo…

12bfe18

…r Dockerfile

Add stringValue of missing types

62ba79c

Unify toJson'xxx' APIs the same way like setValue

6286896

etherealjoy closed this Jun 30, 2018

stkrwork reviewed Jun 30, 2018

View reviewed changes

etherealjoy reopened this Jul 2, 2018

JohnAmadis reviewed Jul 2, 2018

View reviewed changes

Rework to remove all pointer usages, pass by const references, simpli…

b6e7e8c

…fy model, add emit signals to default handlers

wing328 merged commit 65bad61 into OpenAPITools:master Jul 26, 2018

etherealjoy deleted the cpp-qt5-server-wip branch July 26, 2018 10:32

wing328 added this to the 3.2.0 milestone Jul 26, 2018

etherealjoy mentioned this pull request Aug 4, 2018

[C++] Addition of a server for Qt5 #268

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Qt5 Server] Add Support for Qt5 server using QHttpEngine #322

[Qt5 Server] Add Support for Qt5 server using QHttpEngine #322

etherealjoy commented Jun 14, 2018 •

edited

Loading

wing328 commented Jun 14, 2018

etherealjoy commented Jun 14, 2018 •

edited

Loading

wing328 commented Jun 14, 2018

wing328 commented Jun 14, 2018 •

edited

Loading

stkrwork left a comment

stkrwork Jun 28, 2018

etherealjoy Jul 2, 2018 •

edited

Loading

stkrwork Jun 28, 2018

etherealjoy Jun 30, 2018

stkrwork Jun 28, 2018

stkrwork Jun 28, 2018

etherealjoy Jul 2, 2018

stkrwork commented Jun 30, 2018

JohnAmadis Jul 2, 2018

etherealjoy Jul 26, 2018

wing328 commented Jul 3, 2018

etherealjoy commented Jul 3, 2018

wing328 commented Jul 8, 2018 •

edited

Loading

etherealjoy commented Jul 26, 2018

[Qt5 Server] Add Support for Qt5 server using QHttpEngine #322

[Qt5 Server] Add Support for Qt5 server using QHttpEngine #322

Conversation

etherealjoy commented Jun 14, 2018 • edited Loading

PR checklist

Description of the PR

wing328 commented Jun 14, 2018

etherealjoy commented Jun 14, 2018 • edited Loading

wing328 commented Jun 14, 2018

wing328 commented Jun 14, 2018 • edited Loading

stkrwork left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etherealjoy Jul 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stkrwork commented Jun 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wing328 commented Jul 3, 2018

etherealjoy commented Jul 3, 2018

wing328 commented Jul 8, 2018 • edited Loading

etherealjoy commented Jul 26, 2018

etherealjoy commented Jun 14, 2018 •

edited

Loading

etherealjoy commented Jun 14, 2018 •

edited

Loading

wing328 commented Jun 14, 2018 •

edited

Loading

etherealjoy Jul 2, 2018 •

edited

Loading

wing328 commented Jul 8, 2018 •

edited

Loading