feature: Typescript-angular support single request param

[djairhogeuens]

fixes #4465 Add support for singleRequestParameter in typescript-angular generator

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

[djairhogeuens]

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07)

Please have a look :)

[macjohnny]

please don't run the bin/openapi3 scripts

[macjohnny]

thanks for the PR, I will have a closer look soon

[macjohnny]

please add a configuration to https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-angular-petstore-all.sh and https://github.com/OpenAPITools/openapi-generator/blob/master/bin/windows/typescript-angular-petstore-all.bat

[macjohnny]

LGTM
I think we should include it and have a look at the user feedback.

[macjohnny]

@djairhogeuens can you please commit the executable flag of the newly added script in /bin?

[djairhogeuens]

@djairhogeuens can you please commit the executable flag of the newly added script in /bin?

The executable flag was set, I did notice a small mistake in the script itself when comparing it to the windows version. I ran them both locally and they seem to work fine so I commited that fix and will see if CI passes now.

[macjohnny]

the executable flag is still missing:

https://github.com/OpenAPITools/openapi-generator/blob/4083448afd40c84e2c2784e5e929f679be4f3b6f/bin/typescript-angular-v8-petstore-single-request-parameter.sh

see https://github.com/OpenAPITools/openapi-generator/blob/4083448afd40c84e2c2784e5e929f679be4f3b6f/bin/typescript-angular-petstore-all.sh for reference

[djairhogeuens]

Hm strange... In my terminal it showed that the file was executable (and I could execute it) but when checking git ls-files --stage it said that it was not executable. I managed to fix it now :)

[filipvh]

@macjohnny @djairhogeuens Build seems to have timed out?

[macjohnny]

@filipvh I restarted the build

[macjohnny]

@djairhogeuens the CircleCI tests fail due to the docs-page not being up to date. can you please fix this?

[macjohnny]

Please also update the following file: https://github.com/openapitools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/options/TypeScriptAngularClientOptionsProvider.java

[djairhogeuens]

Docs were updated but apparently the order of the parameters matters, fixed it :)
The TypeScriptAngularClientOptionsProvider.java was already updated with the new option

[wing328]

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

[djairhogeuens]

@wing328 When checking in SourceTree it seems correct to me?

[wing328]

@djairhogeuens thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168

[wing328]

@djairhogeuens please have a look at https://github.com/OpenAPITools/openapi-generator/pull/4479/commits and none of the commits is linked to your Github account.