Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Jersey2] Fix typo and script, Log enhancements, HTTP signature, deserialization #6476

Merged
merged 48 commits into from
May 31, 2020

Conversation

sebastien-rosset
Copy link
Contributor

@sebastien-rosset sebastien-rosset commented May 28, 2020

  1. Fix typo in the generated Java jersey2 library
  2. Add -p argument to mkdir in the sample scripts
  3. Add Level.FINE log statement to help troubleshoot deserialization issues.
  4. Add Java jersey2 sample based on OAS 3.0 document with HTTP signature scheme. This helps to validate changes to the mustache templates for HTTP signature do not introduce regressions and can be compiled.
  5. Add unit test to validate deserialization of 'oneOf' schema.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@sebastien-rosset
Copy link
Contributor Author

@wing328

@sebastien-rosset sebastien-rosset changed the title [Java][Jersey2] Fix typo and script, Log enhancements [Java][Jersey2] Fix typo and script, Log enhancements, HTTP signature, deserialization May 29, 2020
@wing328
Copy link
Member

wing328 commented May 31, 2020

We're consolidating ./samples/openapi into ./samples and only use OAS 3 spec moving forward so I'll move the new samples you added under ./samples

@wing328 wing328 merged commit 54e2574 into OpenAPITools:master May 31, 2020
@wing328 wing328 added this to the 5.0.0 milestone May 31, 2020
jimschubert added a commit that referenced this pull request Jun 2, 2020
* master:
  Update Generate.java (#6515)
  Undo PR #6451 (#6514)
  Minor enhancement to Python client generator's code format (#6510)
  [python-experimental] Quicken package loading (#6437)
  [Python][Client] Fix delimiter collision issue #5981 (#6451)
  [Java][Jersey2] add petstore integration tests (#6508)
  UE4 client generator fixes (#6438)
  Fix docs typos (#6478)
  [php-laravel] Show required PHP version in docs (#6502)
  [php-lumen] Show required PHP version in docs (#6501)
  [Java][Jersey2] Fix typo and script, Log enhancements, HTTP signature, deserialization (#6476)
  Remove deprecations 5.0 (#6060)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants