Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust client response handler to be backward compatible with older versions (< 3.5) of Vert.x #854

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

ccozzolino
Copy link
Contributor

@ccozzolino ccozzolino commented Aug 20, 2018

Fix for #834 (Recreated pull request with proper commit author attribution)

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix for #834

Adjusted client response handler to be backward compatible with older versions (< 3.5) of Vert.x.

@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @lopesmcc

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 added this to the 3.2.2 milestone Aug 21, 2018
@wing328 wing328 merged commit 2044c36 into OpenAPITools:master Aug 21, 2018
@wing328 wing328 changed the title Adjust client response handler to be backwards compatible with older … Adjust client response handler to be backwards compatible with older versions (< 3.5) of Vert.x Aug 22, 2018
@wing328 wing328 changed the title Adjust client response handler to be backwards compatible with older versions (< 3.5) of Vert.x Adjust client response handler to be backward compatible with older versions (< 3.5) of Vert.x Aug 22, 2018
@wing328
Copy link
Member

wing328 commented Aug 22, 2018

@ccozzolino thanks for the enhancement, which is included in the v3.2.2 stable release: https://twitter.com/oas_generator/status/1032252335131512832

@ccozzolino ccozzolino deleted the fix_issue834 branch August 22, 2018 15:36
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants