CMake modernization #1246
Merged
CMake modernization #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the include of the export header in avogadrocore.h, which is mainly there to define common symbols and was only adding it as a convenience. Took a first pass at adding the export macro include to the headers that need it, and where obvious removing the avogadrocore.h include if it was not being used. Signed-off-by: Marcus D. Hanwell <marcus@cryos.net>
Move the Avogadro libraries to export their include directories at the target level, remove the more global calls as the libraries were built. This revealed some dependencies that were not explicitly stated, added them and a note to revisit the rendering dependence on core. Signed-off-by: Marcus D. Hanwell <marcus@cryos.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.