vtk: Add missing OpenGL link target #1412
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines and check for the automated tests. |
|
The change is good, but I'm bit confused. We've been building with -DUSE_VTK for ages with no linking issues on Ubuntu. |
|
I suppose it's pulled indirectly by some other target? But |
|
Here are the build results |
|
Looks reasonable once DCO is done (see failing check). |
Without this, linking fails with CMakeFiles/Vtk.dir/vtkAvogadroActor.cpp.o: in function `vtkAvogadroActor::RenderOpaqueGeometry(vtkViewport*)': /usr/src/debug/avogadrolibs/avogadrolibs-1.98.0/avogadro/vtk/vtkAvogadroActor.cpp:56:(.text+0x27a): undefined reference to `glGetFloatv' /usr/bin/ld: /usr/src/debug/avogadrolibs/avogadrolibs-1.98.0/avogadro/vtk/vtkAvogadroActor.cpp:57:(.text+0x28d): undefined reference to `glGetFloatv' /usr/bin/ld: CMakeFiles/Vtk.dir/vtkAvogadroActor.cpp.o: in function `vtkAvogadroActor::RenderTranslucentPolygonalGeometry(vtkViewport*)': /usr/src/debug/avogadrolibs/avogadrolibs-1.98.0/avogadro/vtk/vtkAvogadroActor.cpp:74:(.text+0x4af): undefined reference to `glGetFloatv' /usr/bin/ld: /usr/src/debug/avogadrolibs/avogadrolibs-1.98.0/avogadro/vtk/vtkAvogadroActor.cpp:75:(.text+0x4c2): undefined reference to `glGetFloatv' collect2: error: ld returned 1 exit status Signed-off-by: Antonio Rojas <arojas@archlinux.org>
|
Here are the build results |
|
Here are the build results |
Without this, linking fails with
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.