Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern tool icons #1576

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Modern tool icons #1576

merged 2 commits into from
Jan 18, 2024

Conversation

matterhorn103
Copy link
Contributor

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Matthew J. Milner <matterhorn103@proton.me>
Signed-off-by: Matthew J. Milner <matterhorn103@proton.me>
@matterhorn103
Copy link
Contributor Author

My proposal for a visual refresh of the toolbar icons, to make them more modern and improve clarity of function and distinguishability as discussed on the forum.

Might well be further changes based on further feedback there but for now I thought I'd open a PR so others can try them out.

The icons are now all SVG format to improve scaling, are flat with no gradients, and have in many cases different versions for light and dark mode.

Initially I've set the default icon to be loaded to be the "light" version, as most users will be using that. There's two versions of each icon in each tool directory, even if both icons are actually identical – one with _light appended and one with _dark. This was in the hope that it would make coding the switch easier, as both are always available with a standardized naming convention.

I traced the hand icon in Inkscape, but the original has a Creative Commons license so presumably it is fine to use for an open-source project. It will need attribution though I imagine! I would appreciate it if you checked and sorted the licensing there @ghutchis (assuming you like the icon itself).

Happy for people to add additional code to this PR to make the light/dark switch work, or to have it merge into a different branch.

Copy link
Contributor

Here are the build results
Avogadro2.AppImage
Win64.exe
macOS.dmg
Artifacts will only be retained for 90 days.

@ghutchis
Copy link
Member

I haven't had time to write the light / dark switching code, but will add that as a separate pull request.

@ghutchis ghutchis added the enhancement feature changes / API changes label Jan 18, 2024
@ghutchis ghutchis merged commit 14a7591 into OpenChemistry:master Jan 18, 2024
22 checks passed
@matterhorn103 matterhorn103 deleted the tool_icons branch January 18, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature changes / API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants