Import molequeue client #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryos
force-pushed
the
import-molequeue-client
branch
from
e57de8f
to
2e259d8
Compare
This removes the optional dependency on the MoleQueue client library. This was always a weak point of the MoleQueue design, and I was never happy with the hard dependency on MoleQueue for a tiny client library. It just uses Qt's Network module with some JSON for coordinating job submission. Build this unconditionally when Qt is enabled, leave the directory naming alone. Signed-off-by: Marcus D. Hanwell <marcus@cryos.net>
Needed a few edits for odd use of namespace that was less flexible than desired, it looks a lot simpler now too. Signed-off-by: Marcus D. Hanwell <marcus@cryos.net>
Signed-off-by: Marcus D. Hanwell <marcus@cryos.net>
cryos
force-pushed
the
import-molequeue-client
branch
from
2e259d8
to
fc9969a
Compare
The client is built in, and so removing conditional builds. Some porting of the code to use the renamed namespace/include location. Signed-off-by: Marcus D. Hanwell <marcus@cryos.net>
ghutchis
approved these changes
May 28, 2021
|
Here are the build results |
|
This fixes #585 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.