Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to reverse direction of scroll-to-zoom #778

Merged
merged 5 commits into from
Sep 9, 2021

Conversation

ghutchis
Copy link
Member

@ghutchis ghutchis commented Sep 9, 2021

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

mquevill and others added 4 commits July 15, 2021 13:44
This affects both mouse and touchpad. It also replaces the obsolete .delta() function with .angleDelta(). The pixel-level function .pixelDelta() does not have direct meaning when performing zoom. The conversion between the two delta functions is 1/8, hence the change in scaling to match the pixel-level control speed in Qt.

Signed-off-by: Michael Quevillon <mquevill@nd.edu>
This method is recommended in Qt documentation.

Signed-off-by: Michael Quevillon <mquevill@nd.edu>
…into mquevill-ScrollZoom

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@ghutchis ghutchis linked an issue Sep 9, 2021 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

Here are the build results
Avogadro2.AppImage
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

Here are the build results
Avogadro2.AppImage
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis ghutchis merged commit 22d96d5 into OpenChemistry:master Sep 9, 2021
@ghutchis ghutchis deleted the mquevill-ScrollZoom branch September 9, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zooming with mouse wheel/touchpad is reversed
2 participants