Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Marcus @cryos,
Let me know what you think about this update. It works fine on linux, but I am not sure if it works on other operating systems yet.
A few things that surprised me while I was working through it (that I hope are the same on Mac and Windows also):
cmake -E
for an option to modify permissions, but couldn't find anything). But to my surprise, it is already executable. I hope it retains its executable permissions on Mac and Windows as well.cmake -E copy <SOURCE_DIR>/${YAEHMOP_NAME} ...
. I hope the same is true on Windows and Mac.Anyways, let me know if I should change anything, or if there is a better way of doing anything.
Thanks,
Patrick