-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backported #1525 #2850
Backported #1525 #2850
Conversation
@fballiano pls lt me try something ... if it goes wrong we need a new PR 😎 |
d52f8e9
to
cf57a6a
Compare
cf57a6a
to
2989993
Compare
I would say no, because its a BC break. |
f8e15bc
to
37b6653
Compare
37b6653
to
35373f7
Compare
I changed the code to avoid BC breaks. Please review. (can make a new PR if wanted) |
v19 only
v20 onlySome are related to #2066 ... WIP ... will update later .. |
closing, v19 will freeze sometimes soon anyway |
Since it's not the first time I'm dealing with a merge conflict regarding these files, I thought we could maybe backport #1525 to avoid having that as difference between v19 and v20.
What do you think?