Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump NiiVue to latest version (0.43.3) #3056

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hanayik
Copy link
Contributor

@hanayik hanayik commented May 20, 2024

This PR bumps the version of NiiVue to the latest version available on NPM at the time of this writing. Using the latest version of niivue was also mentioned in #3001.

changes

  • increment @niivue/niivue package version number to 0.43.3

notes

  • There should not be any functional changes. The package in version 0.43.3 is much smaller compared to the older version being used in OpenNeuro.
  • Niivue is also written in TypeScript now, so types are included in the package.
  • There may be slight performance improvements by using the latest version of NiiVue.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.82%. Comparing base (ccb8be8) to head (0dfe2da).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3056       +/-   ##
===========================================
+ Coverage   41.14%   52.82%   +11.68%     
===========================================
  Files         558       14      -544     
  Lines       36382      778    -35604     
  Branches     1113       34     -1079     
===========================================
- Hits        14968      411    -14557     
+ Misses      21198      367    -20831     
+ Partials      216        0      -216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Contributor

⎯⎯⎯⎯⎯⎯ Failed Suites 2 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  packages/openneuro-app/src/scripts/dataset/__tests__/snapshot-container.spec.tsx [ packages/openneuro-app/src/scripts/dataset/__tests__/snapshot-container.spec.tsx ]
 FAIL  packages/openneuro-app/src/scripts/dataset/files/__tests__/file-viewer-type.spec.jsx [ packages/openneuro-app/src/scripts/dataset/files/__tests__/file-viewer-type.spec.jsx ]
SyntaxError: Named export 'Decompress' not found. The requested module 'fflate/browser' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'fflate/browser';
const { Decompress, decompressSync: decompressSync3, gzipSync } = pkg;

 ❯ packages/openneuro-app/src/scripts/dataset/files/viewers/file-viewer-nifti.tsx:3:31
      1| import React, { useEffect, useRef } from "react"
      2| import PropTypes from "prop-types"
      3| import { Niivue } from "@niivue/niivue"
       |                               ^
      4| 
      5| const FileViewerNifti = ({


Error: SyntaxError: Named export 'Decompress' not found. The requested module 'fflate/browser' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'fflate/browser';
const { Decompress, decompressSync: decompressSync3, gzipSync } = pkg;

 ❯ packages/openneuro-app/src/scripts/dataset/files/viewers/file-viewer-nifti.tsx:3:31


⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯


Error: SyntaxError: Named export 'Decompress' not found. The requested module 'fflate/browser' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'fflate/browser';
const { Decompress, decompressSync: decompressSync3, gzipSync } = pkg;

 ❯ packages/openneuro-app/src/scripts/dataset/files/viewers/file-viewer-nifti.tsx:3:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants