Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): added timeout input for deploy #28

Merged
merged 2 commits into from
Jan 10, 2023
Merged

feat(helm): added timeout input for deploy #28

merged 2 commits into from
Jan 10, 2023

Conversation

Wagan8r
Copy link
Contributor

@Wagan8r Wagan8r commented Jan 5, 2023

No description provided.

@Wagan8r Wagan8r requested a review from thesmo as a code owner January 5, 2023 23:36
@linear
Copy link

linear bot commented Jan 5, 2023

ENG-6732 Update worker k8s config with termination grace period

Since we allow phone calls of 4 hours, we need to ensure that we allow a worker to be in a "terminating" state for up to 4 hours as well.

ACs:

  • Update worker terminationGracePeriodSeconds to 144000 seconds (4 hours)
  • Ensure Helm upgrade can handle a 4 hour delay
    • May need to remove "atomic" upgrade config
  • Work with @stephen on testing and configuration

@Wagan8r @zdbrandt
Update .github/workflows/helm-deploy-eks.yml
b4ed750 
Co-authored-by: Zach <3018949+zdbrandt@users.noreply.github.com>
@Wagan8r Wagan8r merged commit 84f377c into main Jan 10, 2023
@Wagan8r Wagan8r deleted the eng-6732 branch January 10, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdbrandt zdbrandt zdbrandt approved these changes

@thesmo thesmo Awaiting requested review from thesmo thesmo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wagan8r @zdbrandt