Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input history shows locked buttons being pressed when focus mode is turned on #826

Open
3 of 4 tasks
jnkhac opened this issue Jan 29, 2024 · 0 comments
Open
3 of 4 tasks
Assignees
Labels
bug Something isn't working

Comments

@jnkhac
Copy link
Contributor

jnkhac commented Jan 29, 2024

Prerequisites

Please check the following before posting an issue / bug report.

  • I am running the latest version of the firmware found HERE
  • I have checked the documentation HERE and found no answer
  • I checked to make sure that this issue has not already been filed HERE
  • I am reporting the issue to the correct repository

Context

Please provide all relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Expected Behavior

When focus mode and input history is enabled, flipping the focus mode switch to the on side should no longer register any of the locked buttons (usually S1, S2, L3, R3, A1, A2) in the input history.

Current Behavior

Locked buttons when focus mode is on still appears in the input history when pressed. The inputs registered in the history also looks like it is being repeatedly pressed.

Steps to Reproduce

  1. Focus mode and input history enabled (with default settings)
  2. Flip the focus mode switch on controller to the on side
  3. Pressed any of the locked buttons
  4. Check if it appears in the input history

Other Notes

  • Focus mode functionally works fine, issue seems to come from input history
  • May only be an issue on devices with a focus switch (e.g. open_core0)
  • May only be affecting my device and I don't have any other RP2040 based devices to test issue
  • I can't upload my BoardConfig.h file but I can copy paste the code later in a comment if needed
@mikepparks mikepparks self-assigned this Jan 29, 2024
@bsstephan bsstephan added the bug Something isn't working label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants