Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix input history showing locked buttons for issue #826 #827

Closed

Conversation

jnkhac
Copy link
Contributor

@jnkhac jnkhac commented Jan 29, 2024

I'm not sure if issue #826 affects any other devices but the changes I made here seems to work on my device.

@TheTrainGoes
Copy link
Contributor

Hey @jnkhac - I tested this but it was not working as intended.

I will test again tomorrow on it.

@TheTrainGoes
Copy link
Contributor

Hi @jnkhac ,

Following up to see if you had any updates for this.

@jnkhac
Copy link
Contributor Author

jnkhac commented Feb 12, 2024

Hi @TheTrainGoes,

Sorry I've been putting this off for a bit. I haven't been able to find any comments on the discord about the issue so I'm guessing that it only happen on my controller. I've also tried the firmware from the seller and the same issue still occurs. I thought it might've been a hardware issue so I opened up my controller to see but I don't know enough to tell if there's a problem other than looking at the soldering job.

Could you tell me what controllers you tested this with? It will just be for future reference when I buy another controller to test it on. Other than that I'll close the PR in a few days since the fix doesn't seem to work on all controllers and I don't have another controller to test it currently.

@jnkhac jnkhac closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants