Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED button press fade across all themes. #813

Merged
merged 17 commits into from
Jan 26, 2024

Conversation

jmrochuk
Copy link
Contributor

Move LED animation fade into animation base class so it works for all themes
Move fade up/down shortcut to S1+S2 + L3/R3

Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, super clean! Really good improvements on moving around those variables.

This was also tested a bunch at my locals and everyone loved it!

@arntsonl arntsonl merged commit d8f7183 into OpenStickCommunity:main Jan 26, 2024
30 checks passed
@jmrochuk jmrochuk deleted the static-led-fade branch January 26, 2024 21:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants