Added turbo rings/squares to more layouts #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate the work on these @jnkhac . We have some overall display changes coming up that may render some of this redundant but this has been on my backlog to do so thank you. I will check these all out and report back. I asked in your other PR, but if you are in Discord please toss me a DM. |
TheTrainGoes
approved these changes
Jan 29, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Inner turbo rings/squares added to more button layouts.
Inner squares example:
Inner circles looks the same as layouts that already had turbo rings.
Question:
Should I have opened an issue first stating a new addition and if I was going to work on it then make a pull request?