Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GP2040-CE Input Driver system rehaul #830

Merged

Conversation

arntsonl
Copy link
Contributor

@arntsonl arntsonl commented Feb 4, 2024

This is a major overhaul of the USB input driver system.

All input drivers have been moved to their own child class with GPDriver set as the parent class interface.

Why: This makes adding new systems, modifying current systems, and maintaining support WAY easier.

How: This greatly simplifies where each report, report size, update mechanism, and USB calls lives and keeps the majority of our TinyUSB host code intact.

This also moves the update, send_report, send_report_cb, and get_report logic over to the input driver to handle all of these changes. this will give the input driver more control over USB and let gp2040 main pass this along.

@arntsonl arntsonl marked this pull request as ready for review February 6, 2024 19:30
Small change to xbone driver to remove unused variable and set last report to 0 in initialize
Copy link
Contributor Author

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is looking clean

@arntsonl arntsonl merged commit 43358ed into OpenStickCommunity:main Feb 7, 2024
30 checks passed
@arntsonl arntsonl deleted the 202400120_inputdriver_revamp branch February 26, 2024 20:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant