populate the PS3 analog values for buttons #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PS3 face buttons are technically analogs like L2/R2. they were declared in the payload but never used, but apparently Marvel vs. Capcom 2 uses the analog values, so use the digital button state to populate the fake "analog" values and get the game working. this also confirms the order of the axes declared in HIDDescriptors.h, which is nice. this *ALSO* means MvC2 (and who knows what else) has a predefined notion of what's in the payload bytes despite the interface descriptor, so that's interesting, but whatever I WANNA TAKE YOU FOR A RIDE Fixes OpenStickCommunity#785
arntsonl
approved these changes
Feb 17, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS3 face buttons are technically analogs like L2/R2. they were declared in the payload but never used, but apparently Marvel vs. Capcom 2 uses the analog values, so use the digital button state to populate the fake "analog" values and get the game working.
this also confirms the order of the axes declared in HIDDescriptors.h, which is nice.
this ALSO means MvC2 (and who knows what else) has a predefined notion of what's in the payload bytes despite the interface descriptor, so that's interesting, but whatever
I WANNA TAKE YOU FOR A RIDE
Fixes #785