PS4 de-hack: only force a report when the reports are otherwise idle #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of sending a forced report every X ms no matter what, this moves the check to only occur when the new report matches the last sent report for X ms, since if the user is creating lots of valuable (changing) input, we don't need to force one
arntsonl
approved these changes
Feb 28, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sending a forced report every X ms no matter what, this moves the forced report to only occur when the new report matches the last sent report for X ms, since if the user is creating lots of valuable (changing) input, we don't need to force one.
I think 250ms is fair in this new model, but we can test it later and bump it up to say 500ms if we don't like 250ms for whatever reason. 250ms seemed like a good compromise between stuck inputs and minimal effect on active gaming, but we can dial it in.