Update turbo LED logic #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I can test tomorrow if needed |
arntsonl
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Cool, looks like an easy fix to the Turbo LED logic. Thanks @FeralAI and @SavageCore !!
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous Turbo update PR assumed the LED was active low, so the LED current would sink from +V. This caused incorrect and odd LED behavior for the more common use case of connecting LED+ to a GPIO pin.
This PR updates the default logic to use active high to drive the turbo LED, similar to #883, but also cleans up the LED state logic and allows overriding via board config using a define. This wasn't added as a togglable option via web config, but can be added if we think it's beneficial.
I also renamed the slightly ambiguous
turboButtonsPressedvariable toturboButtonsMask, which @SavageCore brought up when we discussed turbo behavior.