LayoutManager & button layout enhancements/fixes #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added methods to webconfig.cpp for exposing LED and Display layout structures
mikepparks
changed the title
arntsonl
approved these changes
Mar 19, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Addresses a bug with the Input History button glyph LUT that would cause the firmware to crash when run from a Debug build state.
Enhancements:
LayoutManager was created to allow sharing of built-in and custom layouts beyond the use of the OLED Display. This also includes two new API routes for the WebConfig:
This also includes enhancements to the button layouts to change from an unnamed array of parameters to named properties. The defined button layouts will still use the previous structure for brevity, but the names exist to make the layout generation code easier to use.