Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom led theme #943

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Conversation

Pelsin
Copy link
Contributor

@Pelsin Pelsin commented Apr 5, 2024

We have not implemented being able to set color to the function button. this results in an error when pressing it.
Unsure if it was ever intended, the rendering was a biproduct of having an incorrect const.
Api does not support it either, i've removed it so the user doesn't think it's possible to change it until we are done with LED rework.

Before
Screenshot 2024-04-06 at 00 10 49

After
Screenshot 2024-04-06 at 00 11 01

#927

Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I think this was a leftover and we can add it back in

@arntsonl arntsonl merged commit ae9695d into OpenStickCommunity:main Apr 6, 2024
32 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants