Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#445 Add popup in Calendar to enable the show more via popup feature in month view #451

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

wendyyng
Copy link
Collaborator

@wendyyng wendyyng commented Nov 28, 2022

Proposed changes

This PR resolves the #445 by enabling the react-big-calendar to show a popup with all the activities of the selected date when the user clicks '+ more' in the calendar's month view. The activities in the popup are also clickable and show the activity dialog with activity information when clicked.

Checklist

  • Are the issues being addressed linked to this PR?
  • Do all commit messages start with the issue number?
  • Are all code changes sufficiently tested?
  • Are there screenshots for UI changes?

image
image

@wendyyng wendyyng added the enhancement New feature or request label Nov 28, 2022
@wendyyng wendyyng self-assigned this Nov 28, 2022
@wendyyng wendyyng marked this pull request as draft November 28, 2022 22:55
@seidior
Copy link
Member

seidior commented Nov 29, 2022

I see this PR is still in draft status, but it's a simple enough change that I think it can be reviewed now.

Everything builds just fine on my machine. I merged in my latest changes from main (so you have one less task for you to do). Yarn didn't need to delint anything.

Two behaviors I observed that we can chat about in our meeting this morning:

  • If I click the "+[x] more" link, then drag to resize the window to be more narrow, the popup doesn't move with the day in the calendar; it stays put.
  • My expectation by clicking a "+[x] more" link would be that it would only show me the missing items, but it appears the default behavior is to show all items for the day.

If neither of these are addressable/configurable, that's totally fine, and I approve of this PR as it stands now.

@wendyyng
Copy link
Collaborator Author

wendyyng commented Nov 29, 2022

Popup doesn't move with the day in the calendar

  • You are right, the popup stays put when the window is resized. The example provided by the react-big-calendar also has the behaviour. I took a look at Google Calendar, and their popups also behave this way.

d

  • I also looked at the Issues and PR in react-big-calendar 's GitHub repo. While there are issues and PR related to popup, they are not exactly related to the issues we are having. Just in case if you are interested:
  1. fix: update to current react-overlays to constrain popup within the Month container
  2. Popup repositions to top-left of window on resize. The popup on the month view repositions to top left of window on resize. (Not the issue we have)

I think for now it seems like there is no quick fix for this.

@wendyyng
Copy link
Collaborator Author

wendyyng commented Nov 29, 2022

  • "+[x] more" link would be that it would only show me the missing items

"+[x] more" link would only show the missing items

  • Personally I think it should include all the activities instead of just the missing items. But other users may have different expectations.
  • Again I looked at Google Calendar and their popup includes all activities. Other calendars might handle their popups differently though.

e

c

@wendyyng wendyyng marked this pull request as ready for review November 29, 2022 20:51
@seidior
Copy link
Member

seidior commented Nov 29, 2022

@wendyyng Awesome, thanks for doing that research! Then I agree, this is ready to go.

Copy link
Collaborator

@rrabinovitch rrabinovitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes appear as expected on my local machine, and I'm in agreement with Wendy re: having the popup include all activities!

@wendyyng wendyyng merged commit d47098d into main Nov 29, 2022
@wendyyng wendyyng deleted the 445-show-more-in-calendar-month-view branch November 29, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking '+ more' in the calendar's month view should show all the activities in the popup
3 participants