Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding sidebar to scriptViewSourcePage #389

Closed
Martii opened this issue Oct 23, 2014 · 4 comments
Closed

Consider adding sidebar to scriptViewSourcePage #389

Martii opened this issue Oct 23, 2014 · 4 comments
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.

Comments

@Martii
Copy link
Member

Martii commented Oct 23, 2014

This was omitted in the current dev and pro since it's never been there.

Discuss what would be added to it if it is implemented... making this team biz because of this.

This is separated out to facilitate keeping things from getting hung for months like it did in #150

NOTE: I am not assigning myself to this because I'd like to hear what others have to say. Feel free to take it with expected discussion. e.g. sell it. :)
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. team biz This is similar to a meta discussion. UI Pertains inclusively to the User Interface. needs discussion Blah, blah, blah, wahh, wahh, wahh, etc. labels Oct 23, 2014
Martii referenced this issue in Martii/OpenUserJS.org Oct 23, 2014
Attempt to add the Script Page Header to the Source Code Page
9a508dd 
* Works on dev
* There is probably some redundant, unused, mustache options set since this is merged/modified code from `script.js` e.g. not efficient at the moment.
* Breadcrumbs are slightly off position wise due to the sidebar being absent

Perhaps the fix needed for OpenUserJS#150. This is my least familiar portion of the code but trying to learn it now... hopefully with the help of some others. :)
@Martii Martii changed the title Consider adding sidebar to script sourceViewSourcePage Consider adding sidebar to scriptViewSource Page Oct 23, 2014
@Martii Martii changed the title Consider adding sidebar to scriptViewSource Page Consider adding sidebar to scriptViewSourcePage Oct 23, 2014
@Martii
Copy link
Member Author

Martii commented Oct 23, 2014

jeesh major human paste malfunction. Corrected subject... going back to slumber soon. heh. :)

@Martii
Copy link
Member Author

Martii commented Feb 22, 2016

I've had about 14 months to think about this... I really don't see a benefit to adding an empty sidebar to the Source Code page.

Closing due to lack of interest.

@Martii Martii closed this as completed Feb 22, 2016
@Martii Martii self-assigned this Nov 29, 2017
@Martii Martii reopened this Nov 29, 2017
@Martii
Copy link
Member Author

Martii commented Nov 29, 2017

Partial interest now...

Martii added a commit to Martii/OpenUserJS.org that referenced this issue Nov 29, 2017
@Martii
Add Author Tools sidebar to scriptViewSourcePage
29d023b 
* Move/show relevant author tools there

Applies to OpenUserJS#389 and post OpenUserJS#438
@Martii Martii mentioned this issue Nov 29, 2017
Merged
Martii added a commit that referenced this issue Nov 29, 2017
@Martii
Add Author Tools sidebar to scriptViewSourcePage (#1291)
b1e9f02 
* Move/show relevant author tools there

Applies to #389 and post #438

Auto-merge
@Martii Martii removed needs discussion Blah, blah, blah, wahh, wahh, wahh, etc. team biz This is similar to a meta discussion. labels Nov 29, 2017
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Nov 30, 2017
@Martii
More Author Tools bits
9930181 
* `@copyright` structure
* Fix UI glitch with a work-around of pre-ordering and dropup class

Applies to OpenUserJS#389
@Martii Martii mentioned this issue Nov 30, 2017
Merged
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Nov 30, 2017
@Martii
Correct to since date not updated date
99f96af 
Post OpenUserJS#1292 and applies to OpenUserJS#389
Martii added a commit that referenced this issue Nov 30, 2017
@Martii
More Author Tools bits (#1292)
82f4580 
* More Author Tools bits

* `@copyright` structure
* Fix UI glitch with a work-around of pre-ordering and dropup class

Applies to #389

* Correct to since date not updated date

Post #1292 and applies to #389

Auto-merge
@Martii
Copy link
Member Author

Martii commented Jun 22, 2018

This is more or less done for logged in users... may be added to but closing.

@Martii Martii closed this as completed Jun 22, 2018
@Martii Martii removed their assignment Jun 22, 2018
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Dec 15, 2018
@Martii
Repair lockdown meta url notice on Source Code page
d565499 
* Link in the FAQ for this

Post OpenUserJS#944 OpenUserJS#970 OpenUserJS#389 ... missed somewhere around OpenUserJS#976 to OpenUserJS#1208 *(vaguely recall this was on the script homepage originally and moved to source code page)*. Needed for OpenUserJS#1548 to calm network traffic issues which appear to be global with Level3. Over 17,000 sites are down according to pingdom.
@Martii Martii mentioned this issue Dec 15, 2018
Merged
Martii added a commit that referenced this issue Dec 15, 2018
@Martii
Repair lockdown meta url notice on Source Code page (#1549)
996dd3c 
* Link in the FAQ for this

Post #944 #970 #389 ... missed somewhere around #976 to #1208 *(vaguely recall this was on the script homepage originally and moved to source code page)*. Needed for #1548 to calm network traffic issues which appear to be global with Level3. Over 17,000 sites are down according to pingdom.

Auto-merge
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Martii