Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed the comment editor #1204

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Embed the comment editor #1204

merged 1 commit into from
Oct 27, 2017

Conversation

Martii
Copy link
Member

@Martii Martii commented Oct 27, 2017

Closes #1197

@Martii
Embed the comment editor
2ecdf9f 
* Few minor HTML fixes
* Rewrote client side script to not be in jQuery. Polyfill for older browsers.. applies to OpenUserJS#904
* Reference FAQ and GFM

Closes OpenUserJS#1197
@Martii Martii added bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. labels Oct 27, 2017
@Martii Martii merged commit 7433c5e into OpenUserJS:master Oct 27, 2017
@Martii Martii deleted the Issue-1197 branch October 27, 2017 00:28
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 30, 2017
@Martii
Some misc near parallel UI changes
938527a 
* Change some icons around
* Add a tooltip
* Move default licensing arbitration to view instead of code... allows visual detection

Post OpenUserJS#1204 OpenUserJS#191 Loosely related to OpenUserJS#116, and OpenUserJS#944 via OpenUserJS#970
@Martii Martii mentioned this pull request Oct 30, 2017
Merged
Martii added a commit that referenced this pull request Oct 30, 2017
@Martii
Some misc near parallel UI changes (#1208)
0318ec5 
* Change some icons around
* Add a tooltip
* Move default licensing arbitration to view instead of code... allows visual detection

Post #1204 #191 Loosely related to #116, and #944 via #970

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request May 30, 2019
@Martii
Always show the comment reply form
ae0c718 
* Allows some browser back button to work in certain browsers due to logoff condition. Edge use case.

NOTE:
* This is a **work-around** for those browsers not implementing back-browser action in a consistent non-destructive manner. Currently present in Chromium back-ends but not Mozilla based or Safari based. Nice inconsistency google! Perhaps this is a bug to add to their collection. Probable refetch instead of cache pull *(and listen)* in those affected browsers which can be another imposed DoS vector.
* No known current way, w/o additional DoS vector added, to address for newTopic logoff condition e.g. out of luck atm.

Post OpenUserJS#1204

Refs:
* https://openuserjs.org/scripts/AltoRetrato/IMDb_My_Movies_enhancer/issues/does_it_still_work!#comment-16af97e508e *(subtle report not yet done on development)*
* https://stackoverflow.com/questions/39920118/chrome-forces-page-refresh-on-window-history-back *(unanswered and long time issue)*
* OpenUserJS#1548 (comment)  *(about:flags note ... perhaps there is another one to disable bad browser acting)*
@Martii Martii mentioned this pull request May 30, 2019
Merged
Martii added a commit that referenced this pull request May 30, 2019
@Martii
Always show the comment reply form (#1615)
a6c8116 
* Allows some browser back button to work in certain browsers due to logoff condition. Edge use case.

NOTE:
* This is a **work-around** for those browsers not implementing back-browser action in a consistent non-destructive manner. Currently present in Chromium back-ends but not Mozilla based or Safari based. Nice inconsistency google! Perhaps this is a bug to add to their collection. Probable refetch instead of cache pull *(and listen)* in those affected browsers which can be another imposed DoS vector.
* No known current way, w/o additional DoS vector added, to address for newTopic logoff condition e.g. out of luck atm.

Post #1204

Refs:
* https://openuserjs.org/scripts/AltoRetrato/IMDb_My_Movies_enhancer/issues/does_it_still_work!#comment-16af97e508e *(subtle report not yet done on development)*
* https://stackoverflow.com/questions/39920118/chrome-forces-page-refresh-on-window-history-back *(unanswered and long time issue)*
* #1548 (comment)  *(about:flags note ... perhaps there is another one to disable bad browser acting)*

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embed the comment editor
1 participant
@Martii