Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDPR8 #1416

Merged
merged 1 commit into from
Jun 12, 2018
Merged

GDPR8 #1416

merged 1 commit into from
Jun 12, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Jun 12, 2018

  • Use very short session before successful auth. Session "bleeding" briefly mentioned at GDPR5 #1411 . This is "expanded" after successful auth.
  • Output originalMaxAge for sync check in express-session via MongoDB
  • Don't easily expose improper/expired callbacks. Part of Graceful failure #37
  • Remove some currently unneeded return statements already captured by block braces

Related to #604 #1201 #1202 and #1393

@Martii
GDPR8
c3ee2ee 
* Use very short session before successful auth. Session "bleeding" briefly mentioned at OpenUserJS#1411 . This is "expanded" after successful auth.
* Output `originalMaxAge` for sync check in *express-session* via MongoDB
* Don't easily expose improper/expired callbacks. Part of OpenUserJS#37
* Remove some currently unneeded `return` statements already captured by block braces

Related to OpenUserJS#604 OpenUserJS#1201 OpenUserJS#1202 and OpenUserJS#1393
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. security Usually relates to something critical. DB Pertains inclusively to the Database operations. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jun 12, 2018
@Martii Martii merged commit 8c35610 into OpenUserJS:master Jun 12, 2018
@Martii Martii deleted the anotherSessionTweak branch June 12, 2018 08:42
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jun 12, 2018
@Martii
Denote err trapability
2c32dff 
* Currently unused but there if we need it and code sig compliance

Post OpenUserJS#1416
@Martii Martii mentioned this pull request Jun 12, 2018
Merged
Martii added a commit that referenced this pull request Jun 12, 2018
@Martii
Denote err trapability (#1417)
e744a6b 
* Currently unused but there if we need it and code sig compliance

Post #1416 

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jun 12, 2018
@Martii
GDPR9
e4c419a 
* Set secure cookies if applicable... probably going to boot everyone off to reset these. Retested local pro... PASS
* Output the cookie contents... now we need most of it and easier just to pipe it all out

Post OpenUserJS#1416 ... related to OpenUserJS#604
@Martii Martii mentioned this pull request Jun 12, 2018
Merged
Martii added a commit that referenced this pull request Jun 12, 2018
@Martii
GDPR9 (#1419)
e9b369a 
* Set secure cookies if applicable... probably going to boot everyone off to reset these. Retested local pro... PASS
* Output the cookie contents... now we need most of it and easier just to pipe it all out

Post #1416 ... related to #604

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. DB Pertains inclusively to the Database operations. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. security Usually relates to something critical. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii