Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create critical notices conditionals #1633

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Create critical notices conditionals #1633

merged 1 commit into from
Jul 1, 2019
+83 −52

Conversation

Martii
Copy link
Member

@Martii Martii commented Jul 1, 2019

  • Little less prominent for warnings vs. possible critical issue
  • More in line with the docs that mostly say "blue install button"
  • Add updateURL check for all modes and display if present
  • Reorder the UI notices a bit.
  • Some line length conformance

Post #1632 and applies to #1548 #432

@Martii
Create critical notices conditionals
17bc4da 
* Little less prominent for warnings vs. possible critical issue
* More in line with the docs that mostly say "blue install button"
* Add `updateURL` check for all modes and display if present
* Reorder the UI notices a bit.
* Some line length conformance


Post OpenUserJS#1632 and applies to OpenUserJS#1548 OpenUserJS#432
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. security Usually relates to something critical. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. stability Important to operations. labels Jul 1, 2019
@Martii Martii merged commit aaf8c4c into OpenUserJS:master Jul 1, 2019
@Martii Martii deleted the criticalNoticeChange branch July 1, 2019 22:30
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jul 2, 2019
@Martii
Repair some meta and relax detection a bit.
d1542bb 
* Chromium 75.0.3770.90 started spewing this out and it's not in *mime-db* dep (yet?)... Relates to `/install/<username>/<scriptname>.meta.js`. Don't think it has an extension spec based off skimming doc
* Relaxing is temporary atm in lieu of more aggressive re

Post OpenUserJS#1633 OpenUserJS#1632 OpenUserJS#944 and applies to OpenUserJS#1548 OpenUserJS#432
@Martii Martii mentioned this pull request Jul 2, 2019
Merged
Martii added a commit that referenced this pull request Jul 2, 2019
@Martii
Repair some meta and relax detection a bit. (#1634)
d0c33d5 
* Chromium 75.0.3770.90 started spewing this out and it's not in *mime-db* dep (yet?)... Relates to `/install/<username>/<scriptname>.meta.js`. Don't think it has an extension spec based off skimming doc
* Relaxing is temporary atm in lieu of more aggressive re

Post #1633 #1632 #944 and applies to #1548 #432

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. security Usually relates to something critical. stability Important to operations. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii