Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim up the local brute DB a little #981

Merged
merged 1 commit into from
Apr 15, 2016
Merged

Trim up the local brute DB a little #981

merged 1 commit into from
Apr 15, 2016

Conversation

Martii
Copy link
Member

@Martii Martii commented Apr 15, 2016

  • Normalize on username standards and do a precheck so we don't track some obvious bad requests. This should lower the MongoLab traffic a little.
  • Remove a stray comma
  • Fixed a bug in lib detection... technically this was refactored out.
  • Removed last commit unused var

NOTES
Consider keyScript as a preop to make sure we're "trying the right kind of key in the lock first" which just happens to be our installName :)

Applies to #944 and a little to #37 (silence is golden)

Trim up the local brute DB a little
14b33ef 
* Normalize on username standards and do a precheck so we don't track some obvious bad requests. This should lower the MongoLab traffic a little.
* Remove a stray comma
* Fixed a bug in lib detection... technically this was refactored out.
* Removed last commit unused var

**NOTES**
Consider `keyScript` as a preop to make sure we're "trying the right kind of key in the lock first" which just happens to be our `installName` :)

Applies to OpenUserJS#944 and a little to OpenUserJS#37 *(silence is golden)*
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Apr 15, 2016
@Martii Martii merged commit 06edbc2 into OpenUserJS:master Apr 15, 2016
@Martii Martii deleted the Issue-944preKey branch April 15, 2016 12:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii