Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error handling to reduce unhandled exceptions #96

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Update error handling to reduce unhandled exceptions #96

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c06daf
Update error handling to prevent trying to emit an error when the cli…
May 21, 2024
a0f811d
Wrap error emit in try/except per review comment
Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ovos_bus_client/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,13 @@ def on_error(self, *args):
LOG.warning('Could not send message because connection has closed')
elif isinstance(error, ConnectionRefusedError):
LOG.warning('Connection Refused. Is Messagebus Service running?')
elif isinstance(error, ConnectionResetError):
LOG.warning('Connection Reset. Did the Messagebus Service stop?')
else:
LOG.exception('=== %s ===', repr(error))
self.emitter.emit('error', error)
NeonDaniel marked this conversation as resolved.
Show resolved Hide resolved

try:
self.emitter.emit('error', error)
if self.client.keep_running:
self.client.close()
except Exception as e:
Expand Down
Loading