Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow API to get/set type of status report #743

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Allow API to get/set type of status report #743

merged 2 commits into from
Jul 27, 2023

Conversation

LRossman
Copy link
Collaborator

The existing EN_setstatusreport function only allows one to set the level of status reporting and not retrieve this value. A new EN_STATUS_REPORT constant was added, to be used with EN_setoption and EN_getoption, to provide read/write access to the level of status reporting.

The existing EN_setstatusreport function only allows one to set the level of status reporting and not retrieve this value. A new EN_STATUS_REPORT constant was added, to be used with EN_setoption and EN_getoption, to provide read/write access to the level of status reporting.
@eladsal
Copy link
Member

eladsal commented Jul 19, 2023

Thanks @LRossman. How about saying in the 2.3 documentation that this can replace EN_setstatusreport which is kept for backward compatibility?

BTW, I see that some tests are failing, is that new?

@LRossman
Copy link
Collaborator Author

The unit test that was failing had a check to see if retrieving an option whose constant was 26, one higher than the highest defined constant, would cause the retrieval to fail. Since the new EN_STATUS_REPORT constant has a value of 26, the retrieval succeeded causing the test to fail. The simple fix was to replace 26 with 27 in the test code.

@LRossman LRossman merged commit 6b8f9c8 into dev Jul 27, 2023
6 checks passed
@LRossman LRossman deleted the dev-status_report branch August 17, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants